Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation consistently corrects source positions and includes focused unit and acceptance coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Markdown source positions by preserving file lines and restoring dedented column offsets.
Changes:
- Centralizes model creation in
RobotParser._get_model. - Corrects Markdown token line and column positions.
- Adds unit coverage and updates acceptance expectations.
| File | Description |
|---|---|
src/robot/running/builder/parsers.py |
Preserves Markdown positions during parsing. |
utest/running/test_markdownparser.py |
Tests extraction and source positions. |
atest/robot/parsing/data_formats/markdown.robot |
Updates expected error lines. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the quick feedback on #5801! As discussed there, this fixes both line and column numbers, with a few short unit tests this time. 🙂
robotframework/robotcode blocks are replaced with empty lines, so line numbers match the file.RobotParsernow creates models in a shared_get_modelmethod thatMarkdownParseroverrides.Documentationuses column offsets to keep indentation, so documentation that continues into a more indented code block now gets that extra indentation. This should hardly ever happen.Fixes #5801.
AI disclosure: I used AI assistance to implement this change and its tests. I reviewed and tested everything myself.