perf(benchmarks): measure actor wake with native Rust SQLite - #5772
Conversation
|
Stack for rivet-dev/actors
Get stack: change kmlxvnqm |
|
|
||
| async fn measure(&self, id: &str, samples: usize, warmup: usize, cold: bool) -> Result<()> { | ||
| let mut generation = self.generation(id).await.context("initial actor startup")?; | ||
| let mut times = Vec::with_capacity(samples); |
There was a problem hiding this comment.
🔴 High · Read the Guard URL from configuration, not the actor response
ActorsCreateResponse contains only actor: rivet_types::actors::Actor, and that type has no endpoint field. Every bench invocation therefore exits here with missing actor endpoint before issuing a sample. Route /request through the configured RIVET_ENDPOINT (as the existing actor E2E clients do with the x-rivet-* headers) instead of trying to extract an endpoint from the create response.
|
Review: perf(benchmarks): measure actor wake with native Rust SQLite This adds a new opt-in Code quality
Bugs / correctness
Performance / security No concerns. This only runs as an explicit local opt-in binary against a dev Engine/namespace, driven by env vars ( Test coverage No automated tests, but that matches this repo's convention for benchmark harnesses (manual, opt-in, requires a running local Engine) rather than something exercised in CI. Nice README with a clear stage-by-stage comparison table for the rollout flags, which makes the benchmark easy to reproduce. |
No description provided.