Forward-port integer range regression tests to v13 - #8718
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Port the ReScript regression test from rescript-lang#8714 unchanged and regenerate the JavaScript snapshot with the v13 compiler. The compiler already handles these patterns correctly after removing Pisout. Original-commit: 54ab807 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Manuel Vázquez Acosta <mva.led@gmail.com> Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port Manuel Vázquez Acosta's regression test from #8714 to v13. The ReScript source is unchanged; its JavaScript snapshot is regenerated with the current compiler and now checks explicit bounds instead of the v12 unsigned-offset expression.
The test verifies that the record pattern
{status: 502 | 503 | 504}rejects 404, 500, 501, and 505 while accepting all three matching statuses. The v13 compiler already handles this correctly since alpha.6, so this PR only adds regression coverage. The port retains the original commit author and attribution trailers.Validation:
make testpasses, including formatting, 328 OUnit tests, 559 runtime tests, build fixtures, and 741 documentation examples.