useful-not-found-page - Fix the selector after the 2026 blank slate redesign - #10136
Draft
nanami-0713 wants to merge 1 commit into
Draft
nanami-0713 wants to merge 1 commit into
nanami-0713 wants to merge 1 commit into
Conversation
Member
|
Thanks for the PR. Actually this is best done in the init function after mounting the widget: The reason is that :has() selectors are very heavy so we avoid where possible. The CSS should stay unchanged, it's already slate for removal in 2027 |
fregante
marked this pull request as draft
September 29, 2026 11:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub's redesigned 404 blank slate dropped the
go to Overview/go to default brancharia-labels, so both legacy selectors inuseful-not-found-page.cssstopped matching and the buttons are visible again (#10133).The new selector anchors on the stable
error-404-descriptiontest id (the 410 variant'seror-typo is kept, as observed in the feature's own selector list) and hides the blank slate's primary action, reusing the.Blankslate-Action > a:only-childpattern already present for the 301-file rule.Verified against the live DOM of both variants (logged-out fetch + rendered page): the old selectors match 0 elements, the new one matches exactly the one button on each page, and
display: noneapplies after injection.Test URLs
Screenshot
Missing branch, before / after:
Missing file, before / after:
(Screenshots taken by injecting the exact CSS rule of this PR into the live pages listed above.)
Closes #10133