Skip to content

Drop explicit Microsoft.SourceLink.GitHub reference #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 2 commits into from
Sep 15, 2026
Merged

Drop explicit Microsoft.SourceLink.GitHub reference #565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de7e48e
Drop explicit Microsoft.SourceLink.GitHub reference
mgravell Sep 15, 2026
7225c50
Merge branch 'master' into marc/drop-sourcelink
mgravell Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Drop explicit Microsoft.SourceLink.GitHub reference 
The .NET SDK has included and enabled Source Link for GitHub-hosted
repos by default since 8.0.100; our pinned SDK (10.0.101+, rollForward
latestMajor) is well past that. Referencing the package explicitly
overrides the SDK's own bundled version, taking on a dependency and
its future CVE/version churn for nothing.

Verified the generated *.sourcelink.json and packed nuspec <repository>
element are unchanged across all target frameworks (net481, netstandard2.0,
net6.0/8.0/10.0).
  • Loading branch information
@mgravell
mgravell committed Sep 15, 2026
commit de7e48e5d19fab0c64bdb7c17a99e4a18496c279
1 change: 0 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@

<ItemGroup>
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" IncludeAssets="runtime; build; native; contentfiles; analyzers"/>
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All"/>
<!--<PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all"/>-->
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<!-- core build -->
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.401" />
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.7.115" />
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.6.0">
<PrivateAssets>all</PrivateAssets>
Expand Down
Loading