Skip to content

Make integration test expectations robust on clustered / newer-module Redis Enterprise #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 2 commits into from
Jul 1, 2026
Merged

Make integration test expectations robust on clustered / newer-module Redis Enterprise #511

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312a120
test(re): make RE integration expectations version/cluster robust
kiryazovi-redis Jul 1, 2026
c1d0ab2
test(json): assert JSON.DEBUG MEMORY is non-negative (module returns …
kiryazovi-redis Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(json): assert JSON.DEBUG MEMORY is non-negative (module returns … 
…0 on newer builds)
  • Loading branch information
@kiryazovi-redis
kiryazovi-redis committed Jul 1, 2026
commit c1d0ab2d9f106b5fc42e737d564e481b8c5e9520
12 changes: 8 additions & 4 deletions tests/NRedisStack.Tests/Json/JsonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,8 +1073,10 @@ public void Memory(string endpointId)

commands.Set(key, "$", new { a = "hello", b = new { a = "world" } });
var res = commands.DebugMemory(key);
// Newer JSON modules report a smaller size; only assert a real positive size.
Assert.True(res > 0);
// JSON.DEBUG MEMORY reports an implementation-defined size that changed across
// module versions (older builds return a positive byte count; newer builds return 0),
// so only assert a non-negative value rather than a version-specific threshold.
Assert.True(res >= 0);
res = commands.DebugMemory("non-existent key");
Assert.Equal(0, res);
}
Expand All @@ -1089,8 +1091,10 @@ public async Task MemoryAsync(string endpointId)

await commands.SetAsync(key, "$", new { a = "hello", b = new { a = "world" } });
var res = await commands.DebugMemoryAsync(key);
// Newer JSON modules report a smaller size; only assert a real positive size.
Assert.True(res > 0);
// JSON.DEBUG MEMORY reports an implementation-defined size that changed across
// module versions (older builds return a positive byte count; newer builds return 0),
// so only assert a non-negative value rather than a version-specific threshold.
Assert.True(res >= 0);
res = await commands.DebugMemoryAsync("non-existent key");
Assert.Equal(0, res);
}
Expand Down
Loading