Skip to content

support multi-aggregates in TS.[M][REV]RANGE #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 12 commits into from
May 11, 2026
Merged

support multi-aggregates in TS.[M][REV]RANGE #469

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
13a3e42
support multi-aggregates in TS.[M][REV]RANGE
mgravell Apr 27, 2026
17c2f3b
format; fix duplicate ship-file entry
mgravell Apr 27, 2026
0b26ccd
remove `TsAggregations.HasSingle`
mgravell Apr 27, 2026
65f1629
simplify/normalize TsAggregations handling for trivial arrays
mgravell Apr 27, 2026
fa4c177
prefer TsAggregations.IsEmpty
mgravell Apr 27, 2026
677a773
update CI image and limit multi-agg tests to server 8.8+
mgravell Apr 27, 2026
bed9558
mark server 8.8 APIs as [Experimental] where appropriate
mgravell Apr 27, 2026
0ba53f6
optimize args combining
mgravell Apr 30, 2026
c2b1372
sizing
mgravell Apr 30, 2026
da8b665
Merge branch 'master' into marc/multi_agg
mgravell Apr 30, 2026
2f8db70
bad merge
mgravell Apr 30, 2026
64dddc6
more bad merge
mgravell Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize args combining
  • Loading branch information
@mgravell
mgravell committed Apr 30, 2026
commit 0ba53f610a9400205122fe1e252903fe68541611
22 changes: 18 additions & 4 deletions src/NRedisStack/TimeSeries/TimeSeriesAux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
using System.Buffers;
using NRedisStack.Literals;
using NRedisStack.Literals.Enums;
using NRedisStack.DataTypes;
using NRedisStack.Extensions;
using StackExchange.Redis;
using System.ComponentModel;
using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Text;

namespace NRedisStack;

Expand Down Expand Up @@ -299,11 +302,22 @@ public static List<object> BuildMultiRangeArgs(TimeStamp fromTimeStamp,

private static string GetAggregationArgs(TsAggregations aggregations)
{
if (aggregations.Length == 1)
switch (aggregations.Length)
{
return aggregations[0].AsArg();
case 0: return "";
case 1: return aggregations[0].AsArg();
case 2: return $"{aggregations[0].AsArg()},{aggregations[1].AsArg()}";
case 3: return $"{aggregations[0].AsArg()},{aggregations[1].AsArg()},{aggregations[2].AsArg()}";
case 4: return $"{aggregations[0].AsArg()},{aggregations[1].AsArg()},{aggregations[2].AsArg()},{aggregations[3].AsArg()}";
case 5: return $"{aggregations[0].AsArg()},{aggregations[1].AsArg()},{aggregations[2].AsArg()},{aggregations[3].AsArg()},{aggregations[4].AsArg()}";
default:
var sb = new StringBuilder();
for (int i = 0; i < aggregations.Length; i++)
{
if (i != 0) sb.Append(',');
sb.Append(aggregations[i].AsArg());
}
return sb.ToString();
}

return string.Join(",", Enumerable.Range(0, aggregations.Length).Select(i => aggregations[i].AsArg()));
}
}