Skip to content

CI: implement [RunPerProtocol] #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 10 commits into from
Mar 12, 2026
Merged

CI: implement [RunPerProtocol] #464

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e7bf34
Triage for internal report of problem with `TOPK` in high-integrity m…
mgravell Feb 10, 2026
4c710e1
naming
mgravell Feb 10, 2026
3bfdbd6
dotnet format
mgravell Feb 10, 2026
241bcca
Merge branch 'master' into marc/bloom
mgravell Mar 12, 2026
792729d
Update Doc.csproj
mgravell Mar 12, 2026
a8e929e
- avoid leaking test connections in race condition
mgravell Mar 12, 2026
359dfd5
remove redundant attribute
mgravell Mar 12, 2026
898b8de
Merge branch 'master' into marc/bloom
mgravell Mar 12, 2026
e03a7ca
rename test discoverers to avoid ambiguity in the reader
mgravell Mar 12, 2026
d5e6cb3
cleanup test-fixture connections after use
mgravell Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename test discoverers to avoid ambiguity in the reader
  • Loading branch information
@mgravell
mgravell committed Mar 12, 2026
commit e03a7caf05a92fa2170c0302340d21dd12ec185f
12 changes: 6 additions & 6 deletions tests/NRedisStack.Tests/SkipIfRedisTheoryAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ public string? Skip
/// </para>
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
[XunitTestCaseDiscoverer(typeof(TheoryDiscoverer))]
[XunitTestCaseDiscoverer(typeof(ExpandingTheoryDiscoverer))]
public class TheoryAttribute(
[CallerFilePath] string? sourceFilePath = null,
[CallerLineNumber] int sourceLineNumber = -1) : Xunit.TheoryAttribute(sourceFilePath, sourceLineNumber)
{
public class TheoryDiscoverer : Xunit.v3.TheoryDiscoverer
public class ExpandingTheoryDiscoverer : Xunit.v3.TheoryDiscoverer
{
protected override ValueTask<IReadOnlyCollection<IXunitTestCase>> CreateTestCasesForDataRow(ITestFrameworkDiscoveryOptions discoveryOptions, IXunitTestMethod testMethod, ITheoryAttribute theoryAttribute, ITheoryDataRow dataRow, object?[] testMethodArguments)
=> base.CreateTestCasesForDataRow(discoveryOptions, testMethod, theoryAttribute, dataRow, testMethodArguments).ExpandAsync();
Expand All @@ -126,7 +126,7 @@ protected override ValueTask<IReadOnlyCollection<IXunitTestCase>> CreateTestCase
}

[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
[XunitTestCaseDiscoverer(typeof(TheoryDiscoverer))]
[XunitTestCaseDiscoverer(typeof(ExpandingTheoryDiscoverer))]
public class SkipIfRedisTheoryAttribute : TheoryAttribute
Comment thread
cursor[bot] marked this conversation as resolved.
Resolved
{
public SkipIfRedisTheoryAttribute(
Expand Down Expand Up @@ -168,19 +168,19 @@ public SkipIfRedisTheoryAttribute(
/// </para>
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
[XunitTestCaseDiscoverer(typeof(FactDiscoverer))]
[XunitTestCaseDiscoverer(typeof(ExpandingFactDiscoverer))]
public class FactAttribute([CallerFilePath] string? sourceFilePath = null, [CallerLineNumber] int sourceLineNumber = -1)
: Xunit.FactAttribute(sourceFilePath, sourceLineNumber)
{
public class FactDiscoverer : Xunit.v3.FactDiscoverer
public class ExpandingFactDiscoverer : Xunit.v3.FactDiscoverer
{
public override ValueTask<IReadOnlyCollection<IXunitTestCase>> Discover(ITestFrameworkDiscoveryOptions discoveryOptions, IXunitTestMethod testMethod, IFactAttribute factAttribute)
=> base.Discover(discoveryOptions, testMethod, factAttribute).ExpandAsync();
}
}

[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
[XunitTestCaseDiscoverer(typeof(FactDiscoverer))]
[XunitTestCaseDiscoverer(typeof(ExpandingFactDiscoverer))]
public class SkipIfRedisFactAttribute : FactAttribute
{
public SkipIfRedisFactAttribute(
Expand Down
Loading