Skip to content

Add explicit support for SDK net10 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uglide merged 3 commits into from
Feb 3, 2026
Merged

Add explicit support for SDK net10 #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0145132
- add explicit net10 target to lib and tests
mgravell Feb 3, 2026
05005a7
include net10 in test matrix
mgravell Feb 3, 2026
e1f0893
dotnet format
mgravell Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
- add explicit net10 target to lib and tests 
- remove net7 target, long since deprecated (remaining are LTS)
- enable C# 14 and fix minor xunit overload nuance
- use net10 for build and add to CI
  • Loading branch information
@mgravell
mgravell committed Feb 3, 2026
commit 0145132ab4ab0764ae0f76c3705f21eda8020a45
2 changes: 1 addition & 1 deletion .github/actions/run-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ runs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
9.0.x
10.0.x
${{inputs.dotnet-version}}
dotnet-quality: 'ga'

Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<Copyright>2022- Redis, inc.</Copyright>
<Nullable>enable</Nullable>
<LangVersion>13</LangVersion>
<LangVersion>14</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Authors>Redis Open Source</Authors>
<Owners>Redis OSS</Owners>
Expand Down
1 change: 1 addition & 0 deletions NRedisStack.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Build", "Build", "{84D6210F
global.json = global.json
version.json = version.json
tests\dockers\docker-compose.yml = tests\dockers\docker-compose.yml
.github\actions\run-tests\action.yml = .github\actions\run-tests\action.yml
EndProjectSection
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "docs", "docs\docs.csproj", "{4A35FC3C-69BC-4BDB-A4B2-6BFD0DF215AD}"
Expand Down
2 changes: 1 addition & 1 deletion src/NRedisStack/NRedisStack.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;netstandard2.0;net481</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net10.0;netstandard2.0;net481</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageReadmeFile>README.md</PackageReadmeFile>
<PackageIcon>Redis.png</PackageIcon>
Expand Down
2 changes: 1 addition & 1 deletion tests/NRedisStack.Tests/NRedisStack.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0;net481</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0;net481</TargetFrameworks>
<IsPackable>false</IsPackable>
<PreserveCompilationContext>true</PreserveCompilationContext>
</PropertyGroup>
Expand Down
10 changes: 6 additions & 4 deletions tests/NRedisStack.Tests/TopK/TopKTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ public void CreateTopKFilter(string endpointId)

var res = topk.Add(key, "bb", "cc");
Assert.True(res![0].IsNull && res[1].IsNull);
// ReSharper disable once UseCollectionExpression - need to avoid span overload due to TFMs
Assert.Equal(topk.Query(key, "bb", "gg", "cc"), new[] { true, false, true });
Assert.False(topk.Query(key, "notExists"));

Assert.Equal(topk.Count(key, "bb", "gg", "cc"), [1, 0, 1]);
// ReSharper disable once UseCollectionExpression - need to avoid span overload due to TFMs
Assert.Equal(topk.Count(key, "bb", "gg", "cc"), new[] {1L, 0L, 1L});

var res2 = topk.List(key);
Assert.Equal("bb", res2[0].ToString());
Expand Down Expand Up @@ -62,10 +63,11 @@ public async Task CreateTopKFilterAsync(string endpointId)
var res = await topk.AddAsync(key, "bb", "cc");
Assert.True(res![0].IsNull && res[1].IsNull);

// ReSharper disable once UseCollectionExpression - need to avoid span overload due to TFMs
Assert.Equal(await topk.QueryAsync(key, "bb", "gg", "cc"), new[] { true, false, true });
Assert.False(await topk.QueryAsync(key, "notExists"));

Assert.Equal(await topk.CountAsync(key, "bb", "gg", "cc"), [1, 0, 1]);
// ReSharper disable once UseCollectionExpression - need to avoid span overload due to TFMs
Assert.Equal(await topk.CountAsync(key, "bb", "gg", "cc"), new[] {1L, 0L, 1L});

var res2 = await topk.ListAsync(key);
Assert.Equal("bb", res2[0].ToString());
Expand Down
Loading