Skip to content

test: update argocd-agent self-registration test - #1335

Open
jparsai wants to merge 1 commit into
redhat-developer:masterfrom
jparsai:test-51-1
Open

test: update argocd-agent self-registration test#1335
jparsai wants to merge 1 commit into
redhat-developer:masterfrom
jparsai:test-51-1

Conversation

@jparsai

@jparsai jparsai commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

/kind enhancement

This PR is to sync e2e tests from argocd-operator to gitops-operator which were updated in #1300

@jparsai
test: update argocd-agent self-registration test
342fc14 
Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: dc6a91ba-b083-4e95-a29d-c1ee63ffb273

📥 Commits

Reviewing files that changed from the base of the PR and between 080d177 and 342fc14.

📒 Files selected for processing (1)
  • test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded end-to-end coverage for principal deployment settings, including self-registration and client-certificate secret configuration.
    • Added checks that deployment environment-variable values update when self-registration is disabled or the configured secret name changes.

Walkthrough

The principal deployment environment-variable expectations now include default self-registration values. A new E2E test checks enabled self-registration settings and verifies updated values after the configuration changes.

Changes

Principal self-registration checks

Layer / File(s) Summary
Self-registration environment checks
test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go		 Default expectations include disabled self-registration and an empty client-certificate secret name. The E2E test checks enabled settings, then checks changed settings after the deployment reflects the new secret name.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: olivergondza

Merge Risk: ⚪ Minimal · up to 342fc

The test covers the intended deployment configuration changes; no actionable merge risk remains after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the update to the argocd-agent self-registration test, which matches the main change.
Description check ✅ Passed The description explains that the pull request syncs updated end-to-end tests from argocd-operator to gitops-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign svghadi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jparsai

jparsai commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/test v4.19-kuttl-parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd
@olivergondza olivergondza Awaiting requested review from olivergondza

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jparsai