Add discard support to Mono.sequenceEqual - #4381
Open
hunseonglee wants to merge 1 commit into
Open
hunseonglee wants to merge 1 commit into
hunseonglee wants to merge 1 commit into
Conversation
The operator buffers elements from both sources but cleared its queues without invoking the discard hook on cancellation, on error, when the comparison found a difference, and for the value held while waiting for the other source. Buffered and held elements are now passed to Operators.onDiscard, and the discard behavior is documented on the sequenceEqual javadoc. Signed-off-by: seonghun lee <harrisleesh@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonoSequenceEqualcleared both inner queues with a plainqueue.clear()and silently dropped the held-but-uncomparedv1/v2values on downstream cancel, source error, comparer throw, and the inequality short-circuit — noOperators.onDiscard*anywhere in the operator.This change introduces
discardCurrentValuesAndQueues()(discardingv1,v2and both queues viaOperators.onDiscard/onDiscardQueueWithClear), invoked fromcancel()under the WIP guard, from the drain-loop cancelled branch, and from the internal terminal path. Discard Support javadoc added to all threeMono.sequenceEqualoverloads.Two regression tests added (
discardOnCancel,discardOnMismatch) — both fail onmainwith empty discard collections and pass with the fix;MonoSequenceEqualTestpasses 23/23.Fixes #4378