add test for data-* attributes

Archmonger · Dec 7, 2025 · Jun 19, 2025 · Nov 22, 2025 · Dec 5, 2025 · Dec 5, 2025
commit 617ef91846f0d511b4479af647c80a83143e2a72
diff --git a/src/js/packages/event-to-object/src/index.ts b/src/js/packages/event-to-object/src/index.ts
@@ -139,6 +139,23 @@ function classToObject(x: any, maxDepth: number): object {
       result[key] = x[key];
     }
   }
+
+  // Explicitly include dataset if it exists (it might not be enumerable)
+  if (
+    x &&
+    typeof x === "object" &&
+    "dataset" in x &&
+    !Object.prototype.hasOwnProperty.call(result, "dataset")
+  ) {
+    const dataset = x["dataset"];
+    if (!shouldIgnoreValue(dataset, "dataset", x)) {
+      const converted = deepCloneClass(dataset, maxDepth);
+      if (converted !== maxDepthSignal) {
+        result["dataset"] = converted;
+      }
+    }
+  }
+
   return result;
 }
 

diff --git a/src/js/packages/event-to-object/tests/event-to-object.test.ts b/src/js/packages/event-to-object/tests/event-to-object.test.ts
@@ -372,3 +372,36 @@ test("adds text of current selection", () => {
     isTrusted: undefined,
   });
 });
+
+test("includes data-* attributes in dataset", () => {
+  const div = document.createElement("div");
+  div.setAttribute("data-test-value", "123");
+  div.setAttribute("data-other", "foo");
+
+  const event = new window.Event("click");
+  Object.defineProperty(event, "target", {
+    value: div,
+    enumerable: true,
+    writable: true,
+  });
+  Object.defineProperty(event, "currentTarget", {
+    value: div,
+    enumerable: true,
+    writable: true,
+  });
+
+  checkEventConversion(event, {
+    target: {
+      dataset: {
+        testValue: "123",
+        other: "foo",
+      },
+    },
+    currentTarget: {
+      dataset: {
+        testValue: "123",
+        other: "foo",
+      },
+    },
+  });
+});
diff --git a/src/js/packages/event-to-object/tests/tooling/check.ts b/src/js/packages/event-to-object/tests/tooling/check.ts
@@ -2,7 +2,7 @@ import { expect } from "bun:test";
 import { Event } from "happy-dom";
 // @ts-ignore
 import lodash from "lodash";
-import { convert } from "../../src/index";
+import convert from "../../src/index";
 
 export function checkEventConversion(
   givenEvent: Event,