Log unrecognized font family on Android - #58804
Closed
mosab-nasrallah wants to merge 1 commit into
Closed
mosab-nasrallah wants to merge 1 commit into
mosab-nasrallah wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
@javache I moved this to a new PR because #58751 was closed by accident. This addresses both of your comments:
|
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D122984557. |
cortinico
approved these changes
Oct 2, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@fabriziocucci merged this pull request in c1401a1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, a
fontFamilythat can't be resolved silently falls back to the default system font. iOS logsUnrecognized font family '<name>'in the same case (RCTFont.mm). This adds the same log on Android, only whenTypeface.createfalls back to the default typeface, so valid system families likemonospacedon't log. LikeRCTLogInfoon iOS, it only runs in debug builds.Fixes #58750
Replaces #58751, which was closed by accident when its fork got detached.
Changelog:
[ANDROID] [ADDED] - Log unrecognized font families, matching iOS
Test Plan:
Ran this branch's
ReactFontManager.ktin a test app on an API 35 emulator and checked logcat. Debug build:'FontFamilyThatDoesNotExist'logsUnrecognized font family 'FontFamilyThatDoesNotExist'(once per style)'monospace','serif','sans-serif','sans-serif-medium','cursive', fonts inassets/fonts/and fonts added withaddCustomFontlog nothingRelease build: nothing is logged, including for
'FontFamilyThatDoesNotExist'.Repro: RNTesterPlayground.js