Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Provides the
--direct-mountflag withrclone mount2, and the option is not supported byrclone mountbecause legacy mount library does not support anything like this :This flag makes rclone mount the filesystem directly via syscall.Mount instead of forking fusermount3. There is no fd transfer, no socketpair, and no behaviour SELinux would treat as a violation
By the way, --direct-mount requires access to /dev/fuse and of course appropriate permissions (root, or CAP_SYS_ADMIN plus proper AppArmor or seccomp configuration. I run it as root so these are validated for me.
I have used a coding agent to help me with this issue/PR.
I have run make quicktest, and all passed (once i put rclone in PATH or TestEndToEnd would fail)
I have tested this against the system which triggered the issue (debian 13 with SELinux enabled) and it solved my problem : rclone starts and works immediately even with SELinux enabled with an unchanged policy.
This is my first contribution to rclone, and i am new to go. Do not hesitate to tell me if anything needs changing.
Linked issue
#10024
Checklist
test_allpasses for this backend and if submitting a new backend can provide a test account for the integration tester - see CONTRIBUTING.md.