operations: fix rmdirs failing on directories which only look empty -… - #10011
Open
Karthikvanabhojana1 wants to merge 1 commit into
Open
Karthikvanabhojana1 wants to merge 1 commit into
Karthikvanabhojana1 wants to merge 1 commit into
Conversation
…ixes rclone#9907 Google Drive leaves out of its listings any Google Doc it has no export format for, such as a .gform. rmdirs therefore saw a directory holding only such a file as empty, tried to remove it, and failed the whole run with "directory not empty". A directory which turns out not to be empty is not a failure for rmdirs, whose job is to remove the empty ones, so skip it and carry on. This also covers a file arriving between the listing and the removal. sync already ignores this error when it prunes empty directories. The drive backend reported this case as a bare error rather than fs.ErrorDirectoryNotEmpty, so it now returns the standard error like the other backends, which is what makes it recognisable here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… fixes #9907
Google Drive leaves out of its listings any Google Doc it has no export format for, such as a .gform. rmdirs therefore saw a directory holding only such a file as empty, tried to remove it, and failed the whole run with "directory not empty".
A directory which turns out not to be empty is not a failure for rmdirs, whose job is to remove the empty ones, so skip it and carry on. This also covers a file arriving between the listing and the removal. sync already ignores this error when it prunes empty directories.
The drive backend reported this case as a bare error rather than fs.ErrorDirectoryNotEmpty, so it now returns the standard error like the other backends, which is what makes it recognisable here.
What does this change do?
Linked issue
Fixes #
For new or changed backends
Checklist
test_allpasses for this backend and if submitting a new backend can provide a test account for the integration tester - see CONTRIBUTING.md.