webdav: retry failed Nextcloud chunks in place - #10008
Open
Asthenia0412 wants to merge 1 commit into
Open
Asthenia0412 wants to merge 1 commit into
Asthenia0412 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10005.
Nextcloud chunk uploads currently return a retryable error when a chunk PUT fails. The outer low-level retry then restarts the whole upload, removing the temporary upload directory and sending previously accepted chunks again.
Retry each chunk in place using the configured low-level retry budget, rewinding its repeatable body before each attempt. Once that budget is exhausted, prevent the outer retry from restarting the entire object. The regression test covers both a transient chunk failure and an exhausted retry budget.
Testing
All non-integration WebDAV tests pass together. The unfiltered package run cannot complete in this environment because the integration fixture requires
flock, which is unavailable.