Repository navigation
SWR matplotlib__matplotlib-22696 - #86
Open
richeshgupta wants to merge 1 commit into
Open
richeshgupta wants to merge 1 commit into
richeshgupta wants to merge 1 commit into
Conversation
![razorpay-slash[bot]](https://avatars.githubusercontent.com/in/4548214?s=60&v=4){kind=small}
| # super init delayed after own init because array kwarg requires | ||
| # self._coordinates and self._shading | ||
| super().__init__(**kwargs) | ||
| self.set_mouseover(False) |
There was a problem hiding this comment.
[MEDIUM] QuadMesh constructor silently overrides an explicit mouseover=True kwarg
Issue
self.set_mouseover(False) executes after super().init(**kwargs) has already applied user-supplied artist kwargs, so an explicit mouseover=True passed to QuadMesh or Axes.pcolormesh is silently reset to False.
Evidence
SUSPECTED: A test calling ax.pcolormesh([[1, 2], [3, 4]], mouseover=True) and asserting the returned object's get_mouseover() is True fails with this code, because set_mouseover(False) unconditionally overrides the kwarg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWRBench case matplotlib__matplotlib-22696: pinned base 560681c to head 14090b8 of matplotlib#22696. Benchmark replay, not for merge.