Skip to content

Fixed fall through error in binary operation #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcao-bdai merged 5 commits into from
Jan 10, 2024
Merged

Fixed fall through error in binary operation #117

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7b6eda
Fixed fall through error in binary operation
bokorn-bdaii Jan 4, 2024
5c432b3
add unit test coverage
jcao-bdai Jan 5, 2024
336fbc8
update test + type check
jcao-bdai Jan 5, 2024
b848e7b
updates based on review comments
jcao-bdai Jan 10, 2024
c234e6c
one more test
jcao-bdai Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
one more test
  • Loading branch information
@jcao-bdai
jcao-bdai committed Jan 10, 2024
commit c234e6c7a2ad9591c4f3ce81f7b0ef03944dded6
7 changes: 5 additions & 2 deletions tests/test_pose3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,17 +1285,20 @@ def test_angle(self):
p1a.angdist(other=p2a, metric=metric),
p1a.angdist(other=p2b, metric=metric),
)
# not allowing angdist between mismatched types
# angdist is not implemented for mismatched types
with self.assertRaises(ValueError):
_ = r1.angdist(p1a)

# in general, the _op2 interface allows same type only
with self.assertRaises(ValueError):
_ = r1._op2(right=p1a, op=r1.angdist)

with self.assertRaises(ValueError):
_ = p1a._op2(right=r1, op=p1a.angdist)

# in general, the _op2 interface enforces an isinstance check.
with self.assertRaises(TypeError):
_ = r1._op2(right=(1, 0, 0), op=r1.angdist)

def test_functions(self):
# inv
# .T
Expand Down