Make the tool choosers consistent - #2258
Merged
Merged
Conversation
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2258.quarto.org 🔄 Modified Documents |
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2258.quarto.org 🔄 Modified Documents |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin prerelease
git worktree add -d .worktree/sync-2258-to-prerelease origin/prerelease
cd .worktree/sync-2258-to-prerelease
git switch --create sync-2258-to-prerelease
git cherry-pick -x dab304ac66444f870c8950bfa3a9c42d8a641120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five "Choose your tool" interfaces had different labels and markup, and copied CSS and JS. This PR makes them consistent.
page-choosershortcode (_extensions/page-chooser/) replaces three copies of the markup, CSS and script. Each chooser is now a<nav>named by a visible label, witharia-currenton the active page. The items are in_metadata.yml.tools-tabset:aria-labelledbyon the visible label replacesaria-hiddenplusaria-label. A selected tab no longer changes size.role="button"is removed from the links. The manuscripts logos are decorative (alt=""). The cards now show a visible focus ring (WCAG 2.4.7).<style>in the extensions chooser is removed. The.toolrules are the same in bothtutorial.cssfiles, and these rules no longer apply to other links on the page.An axe scan of the same 32 pages before and after the change shows no new findings. Screenshots below.
Where to check
Related: #2222. This PR adds new files and changes
filters/tools-tabset.lua, which #2222 renames. There is one small conflict instyles.css.