Skip to content

Adds redis-devservices it - #17133

Merged
gastaldi merged 1 commit into
quarkusio:mainfrom
netodevel:feature/netodevel-adds-redis-devservices-it
May 13, 2021
Merged

Adds redis-devservices it#17133
gastaldi merged 1 commit into
quarkusio:mainfrom
netodevel:feature/netodevel-adds-redis-devservices-it

Conversation

@netodevel

@netodevel netodevel commented May 11, 2021

Copy link
Copy Markdown
Contributor

Adds feature integration tests of redis.devservices
To guarantee the functioning of the resource.

@quarkus-bot

quarkus-bot Bot commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

This workflow status is outdated as a new workflow run has been triggered.

Details

Failing Jobs - Building a04cb83

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot

quarkus-bot Bot commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

This workflow status is outdated as a new workflow run has been triggered.

Details

🚫 This workflow run has been cancelled.

Failing Jobs - Building 86ae778

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Cache Maven Repository ⚠️ Check → Logs Raw logs

@quarkus-bot

quarkus-bot Bot commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

This workflow status is outdated as a new workflow run has been triggered.

Details

Failing Jobs - Building 7c8f2ca

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand
geoand requested a review from machi1990 May 11, 2021 07:15
machi1990
machi1990 reviewed May 11, 2021
View reviewed changes
Comment thread integration-tests/redis-devservices/src/test/resources/application.properties Outdated
machi1990
machi1990 suggested changes May 11, 2021
View reviewed changes

@machi1990 machi1990 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful addition. Thanks @netodevel, I left some comments.

netodevel
netodevel commented May 11, 2021
View reviewed changes

@netodevel netodevel left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machi1990, I made the changes, when I can resolve let me know.

Comment thread integration-tests/redis-devservices/src/test/resources/application.properties Outdated
@quarkus-bot

quarkus-bot Bot commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

This workflow status is outdated as a new workflow run has been triggered.

Details

🚫 This workflow run has been cancelled.

Failing Jobs - Building 6ed50d4

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Persist Maven Repo ⚠️ Check → Logs Raw logs

@netodevel

netodevel commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

@machi1990, when you can review again

@machi1990

machi1990 commented May 12, 2021

Copy link
Copy Markdown
Member

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

@netodevel

netodevel commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

@machi1990, when you can review again

LGTM. Can you squash, once it is done I'll merge this PR? Thanks for the great work!

Squash done! Thanks for the review.

machi1990
machi1990 approved these changes May 12, 2021
View reviewed changes

@machi1990 machi1990 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. LGTM.

@machi1990 machi1990 added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 12, 2021
@netodevel

netodevel commented May 13, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the addition. LGTM.

CI passed, lgtm?
🚀

@gastaldi
gastaldi merged commit fb5d886 into quarkusio:main May 13, 2021
@quarkus-bot quarkus-bot Bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 13, 2021
@quarkus-bot quarkus-bot Bot added this to the 2.0 - main milestone May 13, 2021
@netodevel

netodevel commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

@machi1990,
I was thinking about adding these integration tests to all other devservices, what do you think?

To do this I would like to reuse this class: https://github.com/quarkusio/quarkus/blob/c5e430c0425895adc97b85df0978617859b4998c/integration-tests/redis-devservices/src/test/java/io/quarkus/redis/devservices/it/utils/SocketKit.java

Which module do you think this class should stay?

@netodevel netodevel mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@machi1990 machi1990 machi1990 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0.Alpha3

Development

Successfully merging this pull request may close these issues.

3 participants

@netodevel @machi1990 @gastaldi