Repository navigation
Not work with minitest 5.16.X #93
Description
/home/common/.rvm/gems/ruby-3.1.2@pryx/gems/minitest-5.16.0/lib/minitest/test.rb:70:in `srand': no implicit conversion of nil into Integer (TypeError)
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/minitest-5.16.0/lib/minitest/test.rb:70:in `runnable_methods'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/runners/minitest_5.rb:15:in `test_methods'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:90:in `block in suites'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `each'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `each_with_object'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `suites'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:61:in `tests'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:15:in `execute'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/runner.rb:17:in `run'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m.rb:13:in `run'
from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/bin/m:4:in `<top (required)>'
from /home/zw963/.rvm/gems/ruby-3.1.2@pryx/bin/m:25:in `load'
from /home/zw963/.rvm/gems/ruby-3.1.2@pryx/bin/m:25:in `<main>'
from /home/zw963/.rvm/rubies/ruby-3.1.2/bin/ruby_executable_hooks:22:in `eval'
from /home/zw963/.rvm/rubies/ruby-3.1.2/bin/ruby_executable_hooks:22:in `<main>'
rake aborted!
Command failed with status (1): [m test/pryx/pryx_test.rb...]
/home/common/Project/pryx/Rakefile:4:in `block in <top (required)>'
Tasks: TOP => default
(See full trace by running task with --trace)
The last support version is 5.15.0
Activity
felixonmars commentedon Oct 19, 2022
Fixed by #92
zw963 commentedon Oct 20, 2022
@qrush , can we release a new version?
zw963 commentedon Oct 20, 2022
谢谢，肥猫，最近在看 Ruby 吗？不如连 Crystal 一起看看吧。
qrush commentedon Oct 20, 2022
@gi any chance you're up for pushing a new version here? 😅 🙏🏼
zedtux commentedon Oct 21, 2022
Yes, please, release a new version 🙏
merof-code commentedon Oct 25, 2022
I have no idea why, but no matter what, VS Code marketplace shows that 0.9.1 exists, but you cannot download it
windows with wsl2 Ubuntu 22.04.
While all that, I just downgraded minitest version
searls commentedon Nov 18, 2022
@qrush / @gi -- if you're open to it, I'm willing to help maintain m and to get releases like this out the door. I had been incorrectly assuming
mwas unmaintained and thinking of building something inspired by it but it seems like it's still working (except I'm blocked by this issue)qrush commentedon Nov 18, 2022
@searls just invited you.
searls commentedon Nov 18, 2022
@qrush thanks! I can't get the tests to pass without updating bundler (which means I should commit back to the repo). Could I have commit bit too?
searls commentedon Nov 19, 2022
Landed the change in 1.6.1. CI is not happy about it, but all tests passed locally at least.
More broadly, @qrush, if you'd like to talk about ongoing maintenance and feature development for the gem, I've got some ideas about contributing!
qrush commentedon Nov 19, 2022
jrochkind commentedon Dec 13, 2022
Just found this ticket after having this problem -- would love to see a release. Any chance?
searls commentedon Dec 13, 2022
@jrochkind yes this was released in m@1.6.1
jrochkind commentedon Dec 13, 2022
Oh, thanks! And thanks for quick response!
What had I done? Ah, I was just trying minitest in a new project today, and copy-pasted from the README
gem 'm', '~> 1.5.0', so that kept me from using the up-to-date 1.6.1, oops! Thanks!You may want to replace README copy-paste line with
gem 'm', '~> 1.6'? Not only updating to latest minor version, but if it gets out of date again like that, with only two version components, if someone copies-pastes it will still allow 1.7, 1.8, 1.10, etc. Whereas~> 1.5.0only allows 1.5.x.I think I'm learning to never copy-paste version numbers from README, this is the second time this month it's bitten me!
searls commentedon Dec 13, 2022
Thanks for catching this. I just removed the version pins from the README