Preserve dictionary key casing in case-insensitive diff paths - #630
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
ignore_string_case=True, comparing{"User": {"AboutMe": 1}}and{"user": {"aboutme": 2}}reports a path using lowercase keys that do not exist in the first input.exclude_pathsandexclude_regex_pathsusing the original keys consequently fail to exclude the change.Keep case-normalized keys for matching, but use each input's original string key for its tree relationship. This preserves case-insensitive key matching and exposes the second input's spelling through
path(use_t2=True). Numeric and bytes key normalization retain their existing behavior. Reported paths now use original casing, so callers depending on lowercase output paths should update their expectations.Fixes #515.
Validation: the original-path and exclusion regressions failed before the fix. Full suite: 1,276 passed, 44 skipped, one pre-existing macOS
resource.setrlimit(RLIMIT_AS)failure reproduced on the unchanged base. Pyright's 50 existing diagnostics and flake8 diagnostics match the unchanged base after accounting for line shifts.git diff --checkpasses.Disclosure: implemented and tested using OpenAI Codex in an authorized automated contribution session.