Repository navigation
Return raw XID when resource table is absent - #297
Open
barlowa124 wants to merge 1 commit into
Open
barlowa124 wants to merge 1 commit into
barlowa124 wants to merge 1 commit into
Conversation
…lass Display.get_resource_class reads self.resource_classes, which is only populated by the Xlib.display.Display wrapper (xobject layer). Displays opened at the protocol level, as in examples/draw-proto.py, have no such table, so parsing any reply containing a resource-typed field failed with AttributeError: 'Display' object has no attribute 'resource_classes'. Fall back to an empty table so the lookup returns the caller's default, which the reply decoder already handles by passing the raw XID through. Fixes python-xlib#281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #281.
protocol.display.Display.get_resource_classreadsself.resource_classes, an attribute populated only by theXlib.display.Displaywrapper when the xobject layer loads. A display opened at the protocol level, asexamples/draw-proto.pydoes withdisplay.Display()fromXlib.protocol, has no such table. Parsing any reply containing a resource-typed field then failed withAttributeError: 'Display' object has no attribute 'resource_classes', which is the traceback in the issue.The lookup now falls back to an empty table and returns the caller's default. The reply decoder already treats a missing class as "return the raw XID", so protocol-level users get the XID integer back rather than a crash, matching what the test suite's
DummyDisplayhas always done.New
test/test_protocol_display.pycovers the bare-display fallback and the resource-field decode path that raised in the report, plus normal lookups on a populated table.