Skip to content

fix(i18n): reject invalid input in ind_pan and fr_ssn #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jordan-Bourillot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(i18n): reject invalid input in ind_pan and fr_ssn #469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d0074a
fix(i18n/fr): reject comma as gender/Corsica suffix in fr_ssn
Jordan-Bourillot Jun 24, 2026
f0eae3d
fix(i18n/ind): anchor ind_pan so trailing characters are rejected
Jordan-Bourillot Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(i18n/ind): anchor ind_pan so trailing characters are rejected 
ind_pan used re.match(r"[A-Z]{5}\d{4}[A-Z]{1}", ...) with no trailing $,
so any string starting with a valid PAN was accepted -- e.g.
ind_pan('ABCDE9999KEXTRA') returned a match. Anchor the pattern with
^...$, matching the ind_aadhar style just above it.
  • Loading branch information
@Jordan-Bourillot
Jordan-Bourillot committed Jun 24, 2026
commit f0eae3d7708e7390d5584e9140dd8d6d63994947
2 changes: 1 addition & 1 deletion src/validators/i18n/ind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ def ind_pan(value: str):
(Literal[True]): If `value` is a valid PAN card number.
(ValidationError): If `value` is an invalid PAN card number.
"""
return re.match(r"[A-Z]{5}\d{4}[A-Z]{1}", value)
return re.match(r"^[A-Z]{5}\d{4}[A-Z]{1}$", value)
4 changes: 3 additions & 1 deletion tests/i18n/test_ind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ def test_returns_true_on_valid_ind_pan(value: str):
assert ind_pan(value)


@pytest.mark.parametrize("value", ["ABC5d7896B", "417598346012", "AaaPL1234C"])
@pytest.mark.parametrize(
"value", ["ABC5d7896B", "417598346012", "AaaPL1234C", "ABCDE9999KEXTRA"]
)
def test_returns_failed_validation_on_invalid_ind_pan(value: str):
"""Test returns failed validation on invalid ind pan."""
assert isinstance(ind_pan(value), ValidationError)