Add filters.IS_BOT - #5366
Open
kurupdevs wants to merge 1 commit into
Open
Add filters.IS_BOT#5366kurupdevs wants to merge 1 commit into
kurupdevs wants to merge 1 commit into
Conversation
New MessageFilter matching messages whose sender is a bot (telegram.User.is_bot). Channel posts and anonymous-admin messages have no Message.from_user and do not match. Closes python-telegram-bot#5315.
Member
|
Please see my review on the other prs which tried this and do those changes |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5315.
Adds
filters.IS_BOT, aMessageFiltermatching messages whose sender is a bot (telegram.User.is_bot), following the existingIS_AUTOMATIC_FORWARDpattern. Negation works via~filters.IS_BOT, so no separateIS_NOT_BOTis needed. Thefrom_user is Noneguard (channel posts, anonymous-admin messages) is handled inside the filter and covered by a test, since a naivemessage.from_user.is_botwould raiseAttributeError. Tests added intests/ext/test_filters.py(bot matches, human doesn't,from_user=Nonedoesn't).