Compare long numeric prerelease identifiers without integer conversion - #488
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487.
A valid version with a 5,000-digit numeric prerelease parses successfully but raises
ValueErrorwhen compared under Python’s default integer-conversion limit. Compare ASCII numeric prerelease identifiers by normalized digit count and text, preserving numeric-before-text ordering without converting them to integers.The change retains constructor leading-zero comparison behavior, legacy Unicode handling and eager validation. It leaves core version parsing, release/build precedence and the optional native parser unchanged. Regression tests and a changelog fragment are included.
Validation on CPython 3.14.7 with the 4,300-digit limit unchanged:
tests/: 450 passed, one optional-native-backend skip. After annotation and test-literal/formatting-only cleanup, all 86 comparison cases passed again; the algorithm and test AST were unchanged.The supported-Python tox matrix, native backend, coverage and documentation/doctest builds were not run.
OpenAI Codex assisted with the implementation, tests, independent review and this description.