Fix #484: Increment old-style prerelease with dot - #485
Merged
Merged
Conversation
Fix `next_version` to correctly increment old-style prerelease
versions without a dot separator (for example `rc3`).
Previously, calling `next_version("prerelease")` on such versions
would reset the prerelease number to 1 instead of incrementing it.
tomschr
pushed a commit
that referenced
this pull request
Sep 26, 2026
* next_version("prerelease") drops the build on every path except the
old-style one added in #485: 1.2.3-rc.3+build.5 becomes 1.2.3-rc.4, but
1.2.3-rc3+build.5 became 1.2.3-rc4+build.5. Pass build=None there as the
token-change branch below it already does.
* Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
next_versionto correctly increment old-style prerelease versions without a dot separator (for examplerc3). Previously, callingnext_version("prerelease")on such versions would reset the prerelease number to 1 instead of incrementing it.