feat(hvcs-github): support creating GitHub releases as drafts - #1480
Open
sudo-ai-git wants to merge 1 commit into
Open
sudo-ai-git wants to merge 1 commit into
sudo-ai-git wants to merge 1 commit into
Conversation
Add a draft param (default False) to create_release / create_or_update_release across the HVCS interface (github, bitbucket, gitea, gitlab) so GitHub releases can be created as draft. Backward compatible; threads through the GitHub API's draft field. 179 unit tests pass (asset-upload test errors are pre-existing).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1193. Adds support for creating GitHub releases as drafts (previously only pre-releases were supported).
Change: add
draft: bool = Falsetocreate_release/create_or_update_releaseacross the HVCS interface (github, bitbucket, gitea, gitlab + base). Backward-compatible. The GitHub provider now sends"draft": draftinstead of a hardcodedFalse; other providers accept+ignore the param (default False preserves current behavior).Verified:
python-semantic-release's github HVCS unit tests pass (179 passed; thetest_upload_release_asset_failserrors are pre-existing test-env issues, present on cleanmastertoo). Added one assertion update totest_create_or_update_release_when_create_succeedsfor the new call signature.Note: only wires the HVCS-layer param. A follow-up can expose a
release_type=draft/CLI+config option if maintainers want it surfaced end-to-end — happy to add if direction is confirmed.