Handle modern events without ding IDs - #556
Open
MasterDevwi wants to merge 1 commit into
Open
MasterDevwi wants to merge 1 commit into
MasterDevwi wants to merge 1 commit into
Conversation
This was referenced Sep 15, 2026
MasterDevwi
force-pushed
the
fix/cocoa-doorbell-v5-support
branch
from
September 15, 2026 17:25
6dabfeb to
79d4003
Compare
This was referenced Sep 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modern FCM events can omit
event["ding"]["id"]. The current parser raisesKeyError, and repeated notification errors can stop delivery.Fix
event["eventito"]["timestamp"]as a stable fallback only whending.idis absent.Tests
ding.idfallback.Scope and coordination
PR #553 owns
cocoa_doorbell_v5and the other new device model/capability mappings. This PR deliberately contains no device-kind, model, or capability changes and complements #553.Closed PR #518 identified the payload and confirmed that
riidis not unique. The Home Assistant discussion at https://github.com/orgs/home-assistant/discussions/2520 provides downstream context; this parser-only PR alone does not create entities.Validation
python -m compileall -q ring_doorbell testsandgit diff --checkpass. Full local pytest/Ruff validation was unavailable because package-index TLS prevented dependency installation.