Skip to content

Fix a leak in RawJSON() when the argument is rejected #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lelit merged 1 commit into from
Sep 5, 2026
+32 −2
Merged

Fix a leak in RawJSON() when the argument is rejected #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rapidjson.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,6 @@ RawJSON_dealloc(RawJSON* self)
static PyObject*
RawJSON_new(PyTypeObject* type, PyObject* args, PyObject* kwds)
{
PyObject* self = type->tp_alloc(type, 0);
static char const* kwlist[] = {
"value",
NULL
Expand All @@ -475,6 +474,10 @@ RawJSON_new(PyTypeObject* type, PyObject* args, PyObject* kwds)
if (!PyArg_ParseTupleAndKeywords(args, kwds, "U", (char**) kwlist, &value))
return NULL;

PyObject* self = type->tp_alloc(type, 0);
if (self == NULL)
return NULL;

((RawJSON*) self)->value = value;

Py_INCREF(value);
Expand Down
27 changes: 27 additions & 0 deletions tests/test_memory_leaks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,30 @@ def test_failed_validation():
for stat in top_stats[:10]:
# Uhm, with Py 3.14, on macOS, the diff is 3...
assert stat.count_diff <= 3


def test_rejected_rawjson_value():
tracemalloc.start()

snapshot1 = tracemalloc.take_snapshot().filter_traces((
tracemalloc.Filter(True, __file__),))

# start the test
for j in range(1000):
try:
rj.RawJSON(j)
except TypeError:
pass

del j

gc.collect()

snapshot2 = tracemalloc.take_snapshot().filter_traces((
tracemalloc.Filter(True, __file__),))

top_stats = snapshot2.compare_to(snapshot1, 'lineno')
tracemalloc.stop()

for stat in top_stats[:10]:
assert stat.count_diff <= 3
2 changes: 1 addition & 1 deletion typings/rapidjson/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ class Encoder:

@t.final
class RawJSON:
value: RawJSON
value: str
def __new__(cls, value: str) -> RawJSON: ...


Expand Down