Skip to content

Make Ukrainian locale name follow ISO 639, update it and add tests #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Secrus merged 4 commits into from
Aug 20, 2026
Merged

Make Ukrainian locale name follow ISO 639, update it and add tests #957

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3258088
Make Ukrainian locale name follow ISO, update it and add tests
nykula Apr 3, 2026
56769c8
Add Ukrainian test suggested by @afastronomer, and fix formatting
nykula Apr 12, 2026
d07a06c
Keep only 'uk', not 'ua', as discussed with @Secrus
nykula Jul 3, 2026
fd45ad8
Remove forgotten test assert about 'ua' backward compatibility
nykula Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Ukrainian test suggested by @afastronomer, and fix formatting
  • Loading branch information
@nykula
nykula committed Apr 12, 2026
commit 56769c8473e0e4f1a4822b2d156204d572b9b1b0
13 changes: 10 additions & 3 deletions tests/localization/test_uk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def diff_for_humans():
assert d.diff_for_humans(locale=locale) == "кілька секунд тому"
Comment thread
nykula marked this conversation as resolved.
Resolved

# Backward compatibility.
assert d.diff_for_humans(locale=locale) == d.diff_for_humans(locale='ua')
assert d.diff_for_humans(locale=locale) == d.diff_for_humans(locale="ua")

d = pendulum.now().subtract(seconds=2)
assert d.diff_for_humans(locale=locale) == "кілька секунд тому"
Expand Down Expand Up @@ -54,6 +54,9 @@ def diff_for_humans():
d = pendulum.now().subtract(days=2)
assert d.diff_for_humans(locale=locale) == "2 дні тому"

Comment thread
nykula marked this conversation as resolved.
Resolved
d = pendulum.now().subtract(days=5)
assert d.diff_for_humans(locale=locale) == "5 днів тому"

d = pendulum.now().subtract(weeks=1)
assert d.diff_for_humans(locale=locale) == "1 тиждень тому"

Expand Down Expand Up @@ -102,7 +105,9 @@ def diff_for_humans():

def test_format():
d = pendulum.datetime(2026, 4, 3, 1, 2, 5, 123456)
assert d.format("dddd", locale=locale) == "пʼятницю" # Suboptimal, should be п'ятниця, but clock defines it like that.
assert (
d.format("dddd", locale=locale) == "пʼятницю"
) # Suboptimal, should be п'ятниця, but clock defines it like that.
assert d.format("ddd", locale=locale) == "пт"
assert d.format("MMMM", locale=locale) == "квітня"
assert d.format("MMM", locale=locale) == "квіт."
Expand All @@ -116,4 +121,6 @@ def test_format():
assert d.format("L", locale=locale) == "03.04.2026"
assert d.format("LL", locale=locale) == "3 квітня 2026"
assert d.format("LLL", locale=locale) == "3 квітня 2026, 01:02"
assert d.format("LLLL", locale=locale) == "пт, 3 квітня 2026, 01:02" # See note about dddd above.
assert (
d.format("LLLL", locale=locale) == "пт, 3 квітня 2026, 01:02"
) # See note about dddd above.
Loading