Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return
Nonefor empty core-property date elements, matching the existing behavior for absent elements and invalid date strings. Previously theirNonetext reached the parser and raisedTypeError.Fixes #1622.
Tests
created,modified, andlast_printed: empty text, whitespace, and invalid date text. The three empty-element cases fail before the fix; all nine pass afterward.The tests use pytest 8.4.1 and pyparsing 3.2.3 (the latter matches the repository lock). Pyparsing 3.3.3 prevents collection because the existing test helpers use deprecated
delimitedList; no dependency or unrelated helper changes are included here.The optional strict Pyright check is not clean repository-wide: it reports 7,588 errors on both unmodified
masterand this branch, with none in either changed file. This is not reported as a passing type check.AI assistance was used for this fix and tests.