Conversation
…` via flags In C `dn2str()` supports `flags` which works by providing one of `LDAP_DN_FORMAT_UFN`, `LDAP_DN_FORMAT_AD_CANONICAL`, `LDAP_DN_FORMAT_DCE`, `LDAP_DN_FORMAT_LDAPV3`. These symbols do exist in Python, but could not be used ultimately because the Python counterpart was pure Python and did not pass to `dn2str(3)`. Fix python-ldap#257
Contributor
|
On the topic of 3.5, I secretly aimed for last week but trying to avoid swamping Simon and yourself with new code and other work trying to get in the way meant that has slipped. Now that the big things are in and once everyone agrees it's in good shape (thanks for all the typing cleanups BTW!), we can get it out. On trying to get it into 3.4, not sure yet. But also hopefully not urgent to decide? 3.5 is blocking some stuff LDAPCon-wise so I'll prioritise that :) (whereas rushing things into a stable release feels like a Bad Idea(TM)!) |
Contributor
Author
|
It has no urgency. If 3.5 is coming soon, that's fine. And I would probably close this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #466 (#257) and #634.
I need to maintain these patches anyway in a branch, therefor I can also add this as Pull Request and ask again to include it:
I don't see why it shouldn't be part of a 3.4 release - it is 100% backwards compatible, faster, more secure to use.
And when is 3.5 going to be released? This year? And with 3.5 and major API adjustments it is not suitable for certain Debian releases anymore. Meaning: A feature which was request in 2019 will be available in 2029.