Conversation
to satisfy flake8-pyi `Y001 Name of private TypeVar must start with _` Issue: python-ldap#368
spaceone
changed the title
Contributor
|
It has draft in the title but github isn't showing it as draft state. Just checking which it is for review purposes (i.e. have you resolved the stubgen issues or is it pending other stuff?) |
Contributor
Author
|
jeah, it's a draft because the pre-commit linters of python/typeshed#16395 fight against each other. I would prefer that stubgen works OOTB without including privates. But that's a long path. I can't set the official draft state here in github somehow. Please don't merge it. |
mistotebe
marked this pull request as draft
September 23, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to satisfy flake8-pyi
Y001 Name of private TypeVar must start with _.but grr. then one needs to use
stubgen --include-privatewhich will cause:Issue: #368