Fix P410M energy updates during reverse solar power flow - #1751
Open
YouCanCallMeAl wants to merge 1 commit into
Open
YouCanCallMeAl wants to merge 1 commit into
YouCanCallMeAl wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1751 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 157 157
Lines 9932 9933 +1
Branches 1022 1023 +1
=======================================
+ Hits 9266 9267 +1
Misses 471 471
Partials 195 195 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes P410M energy updates when the plug measures reverse power flow from a solar/microinverter source.
The P410M returns malformed JSON for the legacy
get_emeter_datarequest while reporting negative power. This causes the Smart Energy module update to fail and Home Assistant to mark all energy entities unavailable.The P410M provides valid signed power through
get_energy_usage.current_power, so avoid requestingget_emeter_datafor this model.Changes
get_emeter_datafor P410M Smart energy-monitoring devices.get_energy_usageandget_current_power.Device tested
current_power = -19231mW, and the patched CLI reported signed negative power (-21.116 W) without disabling the Energy module.Tests
uv run pytest tests/smart/modules/test_energy.py -quv run pytest -qFixes #1709