Skip to content

improved default time vector for time response functions that takes zeros into account. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 7 commits into from
Oct 17, 2020
Merged

improved default time vector for time response functions that takes zeros into account. #454

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9658e0f
beginnings of code starts with a docstring
sawyerbfuller Aug 17, 2020
afdc5e3
first commit that adds ilayn's default time for step code
bnavigator Aug 18, 2020
a6cac86
Update control/timeresp.py
sawyerbfuller Aug 19, 2020
65ee5ed
removed one more unicode symbol
sawyerbfuller Aug 19, 2020
3d25b8b
more unicode expulsion
sawyerbfuller Aug 19, 2020
23d90d6
curse you python 2. removed '@' sign
sawyerbfuller Aug 19, 2020
c588cdc
Update control/xferfcn.py
sawyerbfuller Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
curse you python 2. removed '@' sign
  • Loading branch information
@sawyerbfuller
sawyerbfuller committed Aug 19, 2020
commit 23d90d652113c15fd8e28b6ade1b37f0b3cd1e8f
5 changes: 4 additions & 1 deletion control/timeresp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
capability and better automatic time vector creation
Date: June 2020

Modified by Ilhan Polat to improve automatic time vector creation

@ilayn ilayn Aug 24, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should get the credit here as far as I am concerned. I really didn't do anything other than geeking out some years ago.

@sawyerbfuller sawyerbfuller Oct 15, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geeking out = valuable! : ) If you're ok with it, I would just say leave it in - I took credit elsewhere in the code for merging things together.

Date: August 17, 2020

$Id$
"""

Expand Down Expand Up @@ -940,7 +943,7 @@ def _ideal_tfinal_and_dt(sys, is_step=True):
# Incorporate balancing to outer factors
l[perm, :] *= np.reciprocal(sca)[:, None]
r[perm, :] *= sca[:, None]
w, v = sys_ss.C @ r, l.T.conj() @ sys_ss.B
w, v = sys_ss.C.dot(r), l.T.conj().dot(sys_ss.B)

origin = False
# Computing the "size" of the response of each simple mode
Expand Down