Repository navigation
fix computation of default response time for constant systems - #383
Merged
Merged
Conversation
1 similar comment
Closed
bnavigator
reviewed
Mar 23, 2020
bnavigator
left a comment
bnavigator
left a comment
Contributor
There was a problem hiding this comment.
Instead of replicating the same code 4 times, put it into an internal function T = _get_response_times(sys, n=100) ?
| # No dynamics; use 100 time steps | ||
| T = range(100) | ||
| else: | ||
| tvec = _default_response_times(sys.A, 100) |
Contributor
There was a problem hiding this comment.
length reduced from 1000 to 100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #374 by added a check for constant systems (
sys.A.shape == (0, 0)) and setting the default response time for those systems to either 1 second (continuous system) or 100 time steps (discrete system).