Repository navigation
Conversation
2 similar comments
Member
|
It looks like this slipped through because there was no unit test that executed this part of the code. Can we add a unit test that covers this section of code (and hence will prevent further errors of this sort)? |
Member
|
I've put together a unit test that exposes this error and also found another small bug in the way the test for frequencies above the Nyquist frequency are handled. I'll generate a separate pull request with the changes. |
murrayrm
added a commit
to murrayrm/python-control
that referenced
this pull request
Feb 24, 2018
As pointed out in PR python-control#192, there were some namespace errors in the statesp module related to checking whether the frequency range as valid for discrete time systems. I added a unit test that covered this code (and exposed the error) and fixed up the namespace problems (as in PR python-control#192). There was also a logic error in the way that frequencies were checked and the warning message referred to the wrong function.
Member
|
Superseded by PR #196. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.