Repository navigation
Allow time_response_plot to plot a list of responses - #1254
Closed
raashish1601 wants to merge 1 commit into
Closed
raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
Member
|
@raashish1601 Can you disclose if and how you used AI tools to do this work? (Please read the README section about contributing and in particular https://numpy.org/doc/stable/dev/ai_policy.html.) |
Author
|
Closing, see #1255 (comment) and the reply below it: this was prepared with an AI coding agent, which the NumPy AI policy referenced in your README does not allow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1171.
time_response_plot()failed when given a list of responses, as in the issue:A list (or tuple) is now handed to
TimeResponseList.plot(), which plots the responses one after the other on the same axes, so the result is the same asresp1.plot(); resp2.plot()(the plot the issue describes as the desired one) and asct.TimeResponseList([resp1, resp2]).plot(). All keyword arguments,*fmtand a list oflabels are passed through. I did not change the color scheme discussed at the end of the issue; the colors are the same as withTimeResponseList.plot()today.Added
test_time_response_plot_listtocontrol/tests/timeplot_test.py(the example from the issue withplot_inputsNone, True, 'overlay' and False, compared line by line withTimeResponseList.plot()). It fails on main and passes here.timeplot_test.py,timeresp_test.py,ctrlplot_test.py,kwargs_test.pyanddocstrings_test.pypass locally (542 passed, 51 skipped), andruff checkis clean.