Skip to content

Lint library code only with ruff check #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 23 commits into from
Feb 3, 2025
Merged

Lint library code only with ruff check #1118

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
dfc0ead
Handle non-* unused import-related messages
roryyorke Jan 25, 2025
eb70132
Silence ruff warnings in __init__.py
roryyorke Feb 1, 2025
c135d2f
Make flatsys/__init__.py ruff-clean
roryyorke Feb 1, 2025
c6dbe07
Silence ruff warnings in matlab/__init__.py
roryyorke Feb 1, 2025
9427eec
Turn f-strings without format-parameters into normal strings (ruff)
roryyorke Feb 1, 2025
5ba2ad5
Fix ruff warnings in robust.py
roryyorke Feb 1, 2025
67fa35d
Apply ruff pyflakes rules to control library only
roryyorke Feb 1, 2025
44db126
Import `ControlArgument` in flatsys.py, with test
roryyorke Feb 1, 2025
7668d2c
Fix ruff "unused value" warnings
roryyorke Feb 1, 2025
ae5a702
Fixed ruff unused argument warning in acker
roryyorke Feb 1, 2025
f9c5b3b
Fix ruff shadowed symbol warning in xferfcn.py
roryyorke Feb 1, 2025
71ea2d7
Fix various ruff unknown symbol warnings
roryyorke Feb 1, 2025
d1ac450
Change _RLSortRoots in rlocus.py to placate ruff
roryyorke Feb 1, 2025
d8b8b2d
Remove unused import
roryyorke Feb 1, 2025
a032506
Silence ruff warning in phaseplot.py
roryyorke Feb 1, 2025
5421a63
Add ruff check Github Action workflow
roryyorke Feb 1, 2025
32ba227
Update docstring_test hashes
roryyorke Feb 2, 2025
b4776c4
Fix comment wording
roryyorke Feb 2, 2025
bd705f2
Remove pyflakes weirdness, use noqa instead
roryyorke Feb 2, 2025
76b2a34
Merge main into lint-lib-only
roryyorke Feb 2, 2025
ce13465
Update dlqe, lqe hashes in docstrings_test.py
roryyorke Feb 2, 2025
b333298
Remove import of unused ControlDimension
roryyorke Feb 2, 2025
18d3d59
Import missing StateSpace
roryyorke Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Silence ruff warnings in __init__.py
  • Loading branch information
@roryyorke
roryyorke committed Feb 2, 2025
commit eb70132a42e72b6adbf76e8e09191ff22799fc1d
9 changes: 7 additions & 2 deletions control/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@
# Import functions from within the control system library
# Note: the functions we use are specified as __all__ variables in the modules

# don't warn about `import *`
# ruff: noqa: F403
# don't warn about unknown names; they come `import *`
# ruff: noqa: F405

# Input/output system modules
from .iosys import *
from .nlsys import *
Expand Down Expand Up @@ -106,8 +111,8 @@
from .sysnorm import *

# Allow access to phase_plane functions as ct.phaseplot.fcn or ct.pp.fcn
from . import phaseplot
from . import phaseplot as pp
from . import phaseplot as phaseplot
pp = phaseplot

# Exceptions
from .exception import *
Expand Down