You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All negative. System is stable. But then when converting _sys1 to state space using tf2ss() returns a system which have positive poles (unstable). I am using Slycot.
I also repeated the same conversion but using scipy and it gives me a stable state space as a result.
This looks like a bug in SLICOT, since tf2ss (which eventually calls statesp._convert_to_statespace) just calls the SLICOT td04ad routine. Confirmed that using scipy.signal.tf2ssgives the correct answer.
Needs a closer took to make sure there is not a python-control bug someplace. If not, we should transfer to the slycot issues list.
I've created a slycot issue (#222) reporting this issue. PR coming that includes a unit test for this case and also adds a method keyword to tf2ss, plus some documentation pointing out the new functionality and the slycot bug.
Activity
murrayrm commentedon Oct 19, 2023
This looks like a bug in SLICOT, since
tf2ss(which eventually callsstatesp._convert_to_statespace) just calls the SLICOTtd04adroutine. Confirmed that usingscipy.signal.tf2ssgives the correct answer.Needs a closer took to make sure there is not a python-control bug someplace. If not, we should transfer to the slycot issues list.
add unit test illustrating issue python-control#935 + add keyword for…
add unit test illustrating issue python-control#935 + add keyword for…
murrayrm commentedon Oct 22, 2023
I've created a slycot issue (#222) reporting this issue. PR coming that includes a unit test for this case and also adds a
methodkeyword totf2ss, plus some documentation pointing out the new functionality and the slycot bug.murrayrm commentedon Nov 23, 2024
Closing this out since this is no longer a python-control issue.