Skip to content

Bug in bdschur with sorting #911

Closed
#912
Closed
Bug in bdschur with sorting#911
#912
Assignees
murrayrm
Milestone
0.9.4

Description

@akhadke-bdai
akhadke-bdai
opened on Jun 9, 2023

There is a bug in the block-diagonal schur matrix computation in line 473. It should be tmodal = tmodal @ rperm.T. Otherwise tmodal @ amodal @ np.linalg.inv(tmodal) $\neq$ a where a is the input to the function.

Activity

  1. akhadke-bdai
    changed the title [-]Bug in bdschur with sorting='continuous'[/-] [+]Bug in bdschur with sorting[/+] on Jun 9, 2023
  2. murrayrm
    added this to the 0.9.4 milestone on Jun 10, 2023
  3. murrayrm
    self-assigned this
    on Jun 10, 2023
  4. murrayrm
    added a commit that references this issue on Jun 10, 2023

    fix bdschur (see issue python-control#911)

    d153aed
  5. murrayrm
    closed this as completedin #912on Jun 10, 2023
  6. murrayrm
    added a commit that references this issue on Jun 10, 2023

    Merge pull request #912 from murrayrm/bdshur_bug-09Jun2023

    f7d18f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions