Skip to content

Sample code for ERA-OKID from UW is broken #847

Description

@RPellowski

What is the issue?

This code must have worked at one time but is now broken. Have no previous experience with it running correctly.

Two issues related to:

Notebook containing the broken code:

  • CH09_SEC03_ERA_OKID.ipynb

Steps to Reproduce

  1. Test on Python 3.10
  2. Run the notebook

Source changes to accommodate the failures

The following changes to the source were needed:
Issue 1. Slice assignment
Change
yFull[:,:,qi],t = impulse(sysFull,T=tspan,input=qi)
to
yFull[:,:,qi:qi+1],t = impulse(sysFull,T=tspan,input=qi)

Change
y1[:,:,qi],t1 = impulse(sysFull,np.arange(200),input=qi)
y2[:,:,qi],t2 = impulse(sysERA,np.arange(100),input=qi)
y3[:,:,qi],t3 = impulse(sysERAOKID,np.arange(100),input=qi)
to
y1[:,:,qi:qi+1],t1 = impulse(sysFull,np.arange(200),input=qi)
y2[:,:,qi:qi+1],t2 = impulse(sysERA,np.arange(100),input=qi)
y3[:,:,qi:qi+1],t3 = impulse(sysERAOKID,np.arange(100),input=qi)

Issue 2. Invalid np array shape
Change
yRandom = lsim(sysFull,uRandom,range(200))[0].T # Output
to
yRandom = lsim(sysFull,uRandom.T,range(200))[0].T # Output

Summary

Potential root causes could be due to changes in this library or in changes to Python or both.

Activity

  1. Scowt commented on Sep 5, 2025

    @Scowt

    Thanks for posting the fixes, I was struggling to get the OKID example working. Confirmed to still be valid with Python 3.13.3 and Control 0.10.2

  2. murrayrm commented on Nov 9, 2025

    @murrayrm
    Member

    Converting this to a discussion topic so that others can find it in the future.

  3. locked and limited conversation to collaborators on Nov 9, 2025
  4. converted this issue into a discussion #1186 on Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions