Skip to content

Calculate poles more smarter for state-space systems #84

Closed
Closed
Calculate poles more smarter for state-space systems#84
Labels
quickfix

Description

@cwrowley
cwrowley
opened on Apr 19, 2016

As pointed out by @pmli in #27, the current implementation involves unnecessarily computing the characteristic polynomial, and then finding its roots. This is inefficient and numerically unstable. Much better to use np.linalg.eigvals.

Activity

  1. cwrowley
    added
    quickfix
    on Apr 19, 2016
  2. murrayrm
    added a commit that references this issue on May 30, 2016

    Merge pull request #91 from mp4096/master

    6dfd5a5

  3. murrayrm commented on May 30, 2016

    @murrayrm
    murrayrm
    on May 30, 2016
    Member

    Addressed in PR #91, now merged into master.

  4. murrayrm
    closed this as completedon May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    quickfix

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions