You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Conda-based CI tests are failing, as seen in PR #755. This this is new behavior. I checked on my local branch and this appears to be happening on the main branch => appears that the issue is outside of this repository. One possibility is an issue with slycot.
Doing a bit of digging. It doesn't look like slycot is the issue, since Python 3.7 without Slycot without cvxopt also crashes. The error messages seem to point to coverage (?). I'm try to isolate things here.
One thing that is odd is that the other test suites pass and they are using xvfb-run. In particular, control-slycot-src.yml seems fine and it runs the full test suite...
It looks like the error occurs when the installation uses a specialized conda environment (versus just installing things in the conda base environment). There are quite a few differences in the various packages that are installed in each case.
Now that the conda error is resolved, there is a new X11 error on the main branch. Something in the GHA runners must have changed between the check run for #755 and after the merge of it.
Activity
[-]CI tests are failing (Slycot issue?)[/-][+]CI tests are failing (coveralls issue?)[/+]murrayrm commentedon Aug 4, 2022
Doing a bit of digging. It doesn't look like slycot is the issue, since Python 3.7 without Slycot without cvxopt also crashes. The error messages seem to point to coverage (?). I'm try to isolate things here.
[-]CI tests are failing (coveralls issue?)[/-][+]CI tests are failing (coverage issue?)[/+]bnavigator commentedon Aug 4, 2022
I don't think that it is coverage.
Looks Qt related which is the default backend for Matplotlib. My first guess is that this is a conda-forge packaging bug on the MPL or Qt side.
More things to try:
MPLBACKENDQT_QPA_PLATFORM=offscreen[-]CI tests are failing (coverage issue?)[/-][+]CI tests are failing (xvfb issue?)[/+]murrayrm commentedon Aug 4, 2022
Using
pytest-xvfbfixes the original crash (which was happening inconfig_test.py), but introduces a new test failure:There is a note saying that we were using
xvfb-runto get the right MPL back end, so that is probably related somehow.murrayrm commentedon Aug 4, 2022
One thing that is odd is that the other test suites pass and they are using
xvfb-run. In particular,control-slycot-src.ymlseems fine and it runs the full test suite...bnavigator commentedon Aug 4, 2022
Yes, it is related. The plain Agg backend does not have the toolbar for the figure manager. We have seen this before: #504 (comment)
So this looks more and more like a qt backend issue in the MPL or Qt packages in conda-forge.
Are you able to determine package version differences in the control-slycot-src vs. the python-package-conda runs?
murrayrm commentedon Aug 5, 2022
It looks like the error occurs when the installation uses a specialized conda environment (versus just installing things in the conda base environment). There are quite a few differences in the various packages that are installed in each case.
bnavigator commentedon Aug 6, 2022
Now that the conda error is resolved, there is a new X11 error on the main branch. Something in the GHA runners must have changed between the check run for #755 and after the merge of it.
bnavigator commentedon Aug 6, 2022
The failures with the invalid DISPLAY variable are totally random. We might just have been lucky in the builds for #755 and #757.
https://github.com/bnavigator/python-control/commits/update-CI
bnavigator commentedon Nov 20, 2022
For the record: the random DISPLAY failure is back. (Maybe due to #796)