Skip to content

allow arrays of step, impulse responses for LTI systems #512

Description

@murrayrm

The current implementation of step and impulse responses for MIMO systems requires the specification of an input channel, so that you always get a SIMO (or SISO) time response. As pointed out in #453, this is not symmetric with the frequency responses, where you can index the input and output channels. There is no reason this couldn't be done consistently for step and impulse responses by just iterating over the set of all input channels. This would help make time and frequency responses more consistent.

Note that one inconsistency will remain: when you compute a forced response, you have to specify the particular input. So in that case you can't index the input channel, only the output channel.

Activity

  1. sawyerbfuller commented on Jan 18, 2021

    @sawyerbfuller
    Contributor
  2. self-assigned this
    on Jan 18, 2021
  3. murrayrm commented on Jan 18, 2021

    @murrayrm
    MemberAuthor

    I have coded up this change, including input=None handling (separate row for each input). Just waiting on merge of #511 before sending a PR.

    This change breaks some of the unit test code that was implicitly assuming that input=None would select the first input. But changes are minor and everything is pretty much backward compatible. I suggest we implement this change into 0.9.0, though, since it may require modification of user code.

  4. added this to the 0.9.0 milestone on Jan 18, 2021
  5. linked a pull request that will close this issueMIMO impulse and step response #514on Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions