Skip to content

Figure 6 in examples/pvtol-nested-ss.py is incorrect #309

Description

@murrayrm

There is something wrong with the figure that is being plotted in examples/pvtol-nested-ss.py, Figure 6. This should be a Bode plot of the loop transfer function with some lines for the unity gain and 180 degree phase. But what comes out is just the gain and phase lines (no Bode plot). This doesn't seem to be due to any recent changes, so must be something that broke a while ago. Probably having to do with the way that "hold" and re-using axes works.

Also: it seems to be OK in 'examples/pvtol-nested.py', so should be something easy to track down and fix.

Activity

  1. billtubbs commented on Jun 9, 2019

    @billtubbs
    Contributor

    Hope I didn't break it.

  2. murrayrm commented on Jun 9, 2019

    @murrayrm
    MemberAuthor

    @billtubbs I checked and it is the same before and after PR #307 and I get the same results => most have broken earlier...

  3. added a commit that references this issue on Jan 2, 2020
  4. added this to the 0.8.3 milestone on Jan 3, 2020
  5. murrayrm commented on Jan 3, 2020

    @murrayrm
    MemberAuthor

    Fixed in PR #361

  6. added a commit that references this issue on Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions