Skip to content

statefbk.acker doesn't use _ssmatrix-converted value of inputs #1100

Closed
#1116
Closed
statefbk.acker doesn't use _ssmatrix-converted value of inputs#1100
#1116
Assignees
murrayrm

Description

@roryyorke
roryyorke
opened on Jan 19, 2025

From gh-1099 ; probably needs a similar treatment to ctrb there.

pyflakes says:

control/statefbk.py:278:5: local variable 'b' is assigned to but never used

code with docstring removed:

def acker(A, B, poles):
    # Convert the inputs to matrices
    a = _ssmatrix(A)
    b = _ssmatrix(B)

    # Make sure the system is controllable
    ct = ctrb(A, B)

Activity

  1. murrayrm commented on Feb 1, 2025

    @murrayrm
    murrayrm
    on Feb 1, 2025
    Member

    FYI, I'm working on a PR that updates use of _ssmatrix (which dates back to NumPy matrix days) and will address this issue.

  2. murrayrm
    self-assigned this
    on Feb 1, 2025
  3. murrayrm
    linked a pull request that will close this issueUpdate _ssmatrix and _check_shape for consistent usage #1116on Feb 2, 2025
  4. murrayrm
    closed this as completedin #1116on Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions