Repository navigation
Correct td04ad - #27
Merged
Merged
Conversation
- corrected TD04AD.f to handle the case of 'C' and static gain tf - corrected transform.pyf, to not allocate zero-dim matrices - added tests for td04ad, one static, one checked against Octave with a transfer function set.
and works for 'C' as well as 'R' added a few tests
This was referenced Jun 29, 2018
bnavigator
pushed a commit
to bnavigator/SLICOT-Reference
that referenced
this pull request
Feb 7, 2021
port of python-control/Slycot#27, see also python-control/Slycot#27 commit 30dc0e5 work on getting 'C' version for td04ad working and checked - corrected TD04AD.f to handle the case of 'C' and static gain tf - corrected transform.pyf, to not allocate zero-dim matrices - added tests for td04ad, one static, one checked against Octave with a transfer function set. commit 7fce83b working TD04AD.f, does not crash any more on edge cases (N=0, NR=0), and works for 'C' as well as 'R' added a few tests
bnavigator
pushed a commit
to bnavigator/SLICOT-Reference
that referenced
this pull request
Feb 14, 2021
port of python-control/Slycot#27, see also python-control/Slycot#27 commit 30dc0e5 work on getting 'C' version for td04ad working and checked - corrected TD04AD.f to handle the case of 'C' and static gain tf - corrected transform.pyf, to not allocate zero-dim matrices - added tests for td04ad, one static, one checked against Octave with a transfer function set. commit 7fce83b working TD04AD.f, does not crash any more on edge cases (N=0, NR=0), and works for 'C' as well as 'R' added a few tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the fortran-side changes from #25