Skip to content

Add sb10yd #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnavigator merged 11 commits into from
Aug 26, 2023
Merged

Add sb10yd #203

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aa22020
Add sb01yd, first commit
KybernetikJo Aug 1, 2023
374434a
Improve docstring, restore the order of procedurces
KybernetikJo Aug 3, 2023
459d501
Fix import order in __init__.py
KybernetikJo Aug 3, 2023
57d0b08
Improve unitest
KybernetikJo Aug 3, 2023
59adbfd
Delete sb10yd.pyf artifact created by f2py
KybernetikJo Aug 17, 2023
2545fe4
Update docstring
KybernetikJo Aug 17, 2023
0b1530f
Add unittest for discrete time case
KybernetikJo Aug 17, 2023
9567694
Delete matplotlib import in unittest
KybernetikJo Aug 18, 2023
4206fef
Clean up pytest, get rid of unittest
KybernetikJo Aug 25, 2023
6ff1902
Update test, add case n=0
KybernetikJo Aug 25, 2023
42b8885
Delint
bnavigator Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete matplotlib import in unittest
  • Loading branch information
@KybernetikJo
KybernetikJo committed Aug 25, 2023
commit 95676942c5655f501d0e471c282ac6f011a67c4a
8 changes: 1 addition & 7 deletions slycot/tests/test_sb10yd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import numpy as np
from scipy import signal

import matplotlib.pyplot as plt

class test_sb10yd(unittest.TestCase):
Comment thread
bnavigator marked this conversation as resolved.
Outdated

def test_sb10yd_cont_exec(self):
Expand Down Expand Up @@ -92,7 +90,7 @@ def test_sb10yd_disc_exec(self):
imag_H_resp = np.imag(H)

n = 2
dico = 1 # 0 for continuous time
dico = 1 # 0 for discrete time
flag = 0 # 0 for no constraints on the poles
n_id, *_ = synthesis.sb10yd(
dico, flag, len(omega),
Expand Down Expand Up @@ -136,10 +134,6 @@ def test_sb10yd_disc_allclose(self):
#print(np.max(abs(H)-abs(H_id)), np.max(abs(H_id)-abs(H)))
#print(np.max(abs(H_id)/abs(H)))

#plt.loglog(omega, abs(H))
#plt.loglog(omega, abs(H_id))
#plt.show(block=True)

# Compare given and identified frequency response up to some toleration.
# absolute(a-b) <= atol + rtol*abolute(b), element-wise true
# absolute(a-b) or absolute(b-a) <= atol, for rtol=0 element-wise true
Expand Down